keep_files=true does not work when force_orphan=true

[trangdata]

I'm using v3, and when I added the force_orphan: true option in my deploy step, keep_files: true seemed to stop working. Existing files on gh-pages were not kept.

The corresponding commit is EpistasisLab/pmlb@67f34be, whose actions log is here.

What I was hoping was to keep the existing files, add changes, then deploy to gh-pages as a single commit. If this is not possible, perhaps a warning would be helpful for users who expected the two options to work together?

[peaceiris]

Thank you for the feedback.

I'm using v3, and when I added the force_orphan: true option in my deploy step, keep_files: true seemed to stop working. Existing files on gh-pages were not kept.

This is a spec. Yes, we need a warning message or termination with a message that tells users that keep_files does not work with the force_orphan option. I did not consider this use case since I am a user of Static Site Generators. (It generates new deployment assets every build.)

Maybe, the keep_files will support working with the force_orphan option in the next major release (version 4).

[trangdata]

Amazing! I look forward to the support! Thank you!

[trangdata]

I should elaborate on why this functionality would be helpful for our use case: We have almost 150+ large HTML files that we sometimes have to regenerate and pushed to gh-pages. force_orphan: true would help us reduce the size of the repo significantly without having to manually squash the gh-pages commits.

Thanks again, and I look forward to the next release!

[peaceiris]

Yes, it looks a practical use case. We need v4.