feat(Accordion): pulled in Penta updates #9876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
requested review from
mcoker,
nicolethoen and
wise-king-sullyman
Contributor
|
Preview: https://patternfly-react-pr-9876.surge.sh A11y report: https://patternfly-react-pr-9876-a11y.surge.sh |
nicolethoen
reviewed
Dec 18, 2023
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
This looks like the sort of update that might need a codemod, right? can we open a codemod issue to track?
AccordionContent - isHidden was removed.
AccordionToggle - isExpanded was moved to AccordionItem.
Anything else?
nicolethoen
approved these changes
Dec 20, 2023
wise-king-sullyman
approved these changes
Jan 4, 2024
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9851
Confirmed that using the latest alpha locally fixes the border color mismatch between this PR and the core v6 staging.
If we want to wait until #9877 gets merged and pulled into the v6 branch, I can update the new example + tests that were added, otherwise the updates shouldn't be too difficult if done during the merge of main into v6.
Additional issues: