chore(Masthead): Consume Penta tokens #9853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlabaj
requested review from
a team,
kmcfaul,
mattnolting,
mfrances17 and
mmenestr
and removed request for
a team
Contributor
|
Preview: https://patternfly-react-pr-9853.surge.sh A11y report: https://patternfly-react-pr-9853-a11y.surge.sh |
thatblindgeye
approved these changes
Dec 7, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Some slight styling differences I'm noticing which may not necessarily be due to Masthead (the hamburger icon in examples is slightly bigger than Core examples, the link color is slightly different), but otherwise looks good react wise
gitdallas
approved these changes
Dec 11, 2023
mattnolting
approved these changes
Dec 15, 2023
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
LGTM! Opened #9897 as followup
packages/react-core/src/components/Masthead/examples/MastheadIconRouterLink.tsx
Show resolved
Hide resolved
andrew-ronaldson
approved these changes
Dec 20, 2023
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Sweet! Approved
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9809
Updated at Masthead demos and examples logos for light variation of masthead.
Note: Masthead:
backgroundColorprop was removed in PR #9774 since light background is now the default with no option to change it.