feat(Table): use pf check/radio for selects #12045
Open
+240
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitdallas <[email protected]>
|
Preview: https://pf-react-pr-12045.surge.sh A11y report: https://pf-react-pr-12045-a11y.surge.sh |
gitdallas
requested review from
a team and
rebeccaalpert
and removed request for
a team
Signed-off-by: gitdallas <[email protected]>
rebeccaalpert
approved these changes
Oct 9, 2025
Comment on lines
+20
to
+23
| /** id for the input element - required by Checkbox and Radio components */ | ||
| id?: string; | ||
| /** name for the input element - required by Radio component */ | ||
| name?: string; |
There was a problem hiding this comment.
I wonder if there's something extra we could/should do with the types here to make these required depending on the passed selectVariant 🤔
Though that might be really hard to do without a breaking change, so this isn't a blocker.
packages/react-table/src/components/Table/utils/transformers.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: gitdallas <[email protected]>
wise-king-sullyman
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12018