feat(Radio/Checkbox): support for aria-describedBy #12042
+120
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitdallas <[email protected]>
|
Preview: https://pf-react-pr-12042.surge.sh A11y report: https://pf-react-pr-12042-a11y.surge.sh |
Signed-off-by: gitdallas <[email protected]>
gitdallas
force-pushed
the
feat/9695-checkbox-radio-aria-describedby
branch
from
a15e207 to
1eba459
Compare
mcoker
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
LGTM though since there is no shiny CSS/UI stuff here, I'm just testing that it works like expected.
- Passing
aria-describedby=''both with and without a description preventedaria-describedbyfrom rendering ✅ - Passing
aria-describedby="foo"renderedaria-describedby="foo"both with and without a description ✅ - Not passing
aria-describedbydid nothing if there is no description ✅ - Not passing
aria-describedbywith a description properly addedaria-description="id-of-description"✅
wise-king-sullyman
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9695