feat(Button): add text wrapper, update icon usage #10663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-10663.surge.sh A11y report: https://patternfly-react-pr-10663-a11y.surge.sh |
tlabaj
requested review from
a team,
mattnolting,
tlabaj and
wise-king-sullyman
and removed request for
a team
nicolethoen
approved these changes
Jul 2, 2024
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Can't wait to see the codemod for plain buttons to pass their children to icon prop
nicolethoen
force-pushed
the
button-wrappers
branch
from
839a64c to
6d708af
Compare
thatblindgeye
approved these changes
Jul 2, 2024
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Looks good. Codemod issue: patternfly/pf-codemods#680
tlabaj
approved these changes
Jul 2, 2024
Contributor
|
FYI ran visual regression tests before/after this update and there were no differences other than demos that dynamically generate content on page render Link to the backstop report - backstop-react-7.2.24.pdf |
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10626
pf-v6-c-button__text, and whenever aniconis passed in that icon will be wrapped bypf-v6-c-button__icon(was previously for non-plain buttons, now applies to all button icons).iconprop instead of an icon child.DualListSelectorControlto have aniconprop that is passed through to the internal Button.This PR will be failing until #10661 is merged due to the core bump.