feat(MenuToggle): consumed Penta updates #10097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-10097.surge.sh A11y report: https://patternfly-react-pr-10097-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss9986_menuTogglePenta
branch
from
ef3e161 to
225545a
Compare
thatblindgeye
requested review from
a team,
kaylachumley,
kmcfaul,
lboehling,
mattnolting and
tlabaj
and removed request for
a team
mattnolting
requested changes
Feb 26, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Looks good, saw one bug
...ages/react-table/src/deprecated/components/Table/__tests__/__snapshots__/Table.test.tsx.snap
Outdated
Show resolved
Hide resolved
kmcfaul
approved these changes
Feb 27, 2024
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
lgtm just an extra space in the docs, but not a blocker
| ### Expanded toggle | ||
|
|
||
| When a user selects a toggle, it becomes expanded and is styled with a blue underline. To flag expanded toggles, and apply expanded styling, use the `isExpanded` property . | ||
| When a user selects a toggle, it becomes expanded and is styled with a blue underline. To flag expanded toggles, and apply expanded styling, use the `isExpanded` property . |
Contributor
There was a problem hiding this comment.
Extra space at the end of the line
mattnolting
approved these changes
Feb 28, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Awesome! Great work, thank you! LPTM
wise-king-sullyman
approved these changes
Mar 4, 2024
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9986
Codemod
This also bumps the Core versions
Additional issues: