Skip to content

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Feb 8, 2024

What: Closes #10047

  • Adds status prop. color does not override the color provided by status, but icon will override the default status icon.
  • Adds pf-m-filled when variant is filled
  • Updates examples with new status labels & changes non-status label icons to CubeIcon

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 8, 2024

@kmcfaul kmcfaul linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than Eric's comment

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit a2c8c7d into patternfly:v6 Feb 28, 2024
@tlabaj tlabaj mentioned this pull request Feb 28, 2024
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label - status labels

5 participants