-
Notifications
You must be signed in to change notification settings - Fork 373
feat(Label): add status, update examples #10073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-10073.surge.sh A11y report: https://patternfly-react-pr-10073-a11y.surge.sh |
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than Eric's comment
fcc8910 to
1b45db7
Compare
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10047
statusprop.colordoes not override the color provided bystatus, buticonwill override the default status icon.pf-m-filledwhen variant isfilled