fix(pfBootstrapDatepicker): added callback function when date changes #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @wywywywy |
Contributor
|
LGTM |
nicolethoen
previously approved these changes
Jul 3, 2018
Member
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
There should be unit tests added to verify the callback is called.
Do we need the two-way binding if we have the callback?
Member
Author
Probably not. I had thought it was an ask in #730 but re-reading the issue maybe not. Would two way binding help app devs if they had a |
Member
|
The callback is better than using $watch. My only thought was it would be a way to reject the selected Date and not update if it were invalid. I'm OK with either way. |
dtaylor113
force-pushed
the
pfbootstrapdatepicker
branch
from
b1c4181 to
1ebfaf6
Compare
dtaylor113
changed the title
Member
Author
|
Hi @jeff-phillips-18, removed two way binding and added unit test PTAL -thanks |
jeff-phillips-18
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two-way binding on
Dateproperty and added the ability for user to define a callback function when date is changed via the picker.Fixes: #730
PR Checklist