pfTableView: Truly turn off pagination by default #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
commented
Jul 7, 2017
| address: "5 Tree Hill Lane", | ||
| city: "Boston", | ||
| state: "Massacusetts" | ||
| } |
Member
Author
There was a problem hiding this comment.
Added more items to the 'Basic' example in order to show that all 12 items are being displayed when pagination is turned off by default.
cdcabrera
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default pagination controls are not displayed in the pfTableView. Unfortunately, items where still being paginated; as a result only the first 10 items would be displayed and with no pagination controls, there was no way to get to the rest of the items.
This PR sets 'pagination=false' in the default dt options, and thus shows all items.
Fixes #513
This will all go away when we integrate the pfPagination component into pfTableView.
@akieling