-
Notifications
You must be signed in to change notification settings - Fork 90
Allow action buttons in empty state for a card/list/table view #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow action buttons in empty state for a card/list/table view #511
Conversation
…h views. Addresses #510.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I noticed that clicking on the empty state action buttons do not update the Events textarea. i believe because the callback function for empty state actions only pass an 'action' parameter, and not an 'item' param, so you cannot reuse the existing perfromActions(actions, item) method. Please update to use a correct callback function, thanks!
|
Other than the one issue I raised, LGTM! |
|
For some reason, which I can't figure out, the actionFn property is becoming undefined for the empty state buttons in any/all examples. I have examples that use a different function for the actionFn property, but when the button is clicked in a browser, that property is undefined. |
Hi, you need to put the actionFn above/before the emptyStateActionButtons array/obj definition. This worked for me: |
…tons in example lists of events. Also fix one spelling error.
dtaylor113
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
cdcabrera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhwood looking good on the PR, if you can squash those commits with a rebase we'll go ahead and merge it in
Add ability to put action buttons in the empty state view for card, list, or table view.
Addresses #510.
This change is