Update to PatternFly version to 3.25.0 and pin to jQuery 2 #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I had to update some broken jQuery API usage in the tests. All tests now pass. A spot check of the API doc reveals components are working as expected. |
dtaylor113
approved these changes
May 25, 2017
jeff-phillips-18
approved these changes
May 25, 2017
Member
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
We need to make sure we link to the PF 3.25 release notes so folks see the breaking changes that come with this.
cdcabrera
approved these changes
May 25, 2017
Member
cdcabrera
left a comment
cdcabrera
left a comment
There was a problem hiding this comment.
[Known] jQuery selections on clean Bower install
bleathem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update to PatternFly 3.25.0 which brings in a jQuery 3 dependency. However not all of Angular-patternfly 3's dependencies are jQuery 3 compatible, so this PR also update bower and npm to use jQuery 2.