Skip to content

Conversation

@jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented May 8, 2017

(already fixed in 4.x)

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optimization applied here, would it need to eventually be applied around line 356 ?

@jeff-phillips-18
Copy link
Member Author

@cdcabrera It ought to be, I will update.

@jeff-phillips-18
Copy link
Member Author

@cdcabrera added the same optimization to wizard directive and next function of wizard step directive. Please re-review. Thanks!

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bleathem
Copy link
Member

Does this PR need to be merged for the 3.24.0 release?

@jeff-phillips-18
Copy link
Member Author

@bleathem yes

@jeff-phillips-18 jeff-phillips-18 merged commit 141f56f into patternfly:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants