Fixes #385 - filter input causes a toolbar view change. #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Entering a value into the pf-toolbar filter input box causes the toolbar viewConfig.viewSelected() handler to be invoked. This causes the view to change if a filter is keyed in while in any other view. This appears to happen because the return keypress is also interpreted as a click event, which triggers the ng-click handler for the view selection button.
jeff-phillips-18
approved these changes
Apr 19, 2017
dtaylor113
approved these changes
Apr 19, 2017
Member
|
Thanks @jglogan! Appreciate the fix/PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entering a value into the pf-toolbar filter input box causes the toolbar viewConfig.viewSelected() handler to be invoked.
This causes the view to change if a filter is keyed in while in any other view.
This appears to happen because the return keypress is also interpreted as a click event, which triggers the ng-click handler for the view selection button.