refactor: removed unused dependencies #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its usage seems to have been removed with commit 3c890c3
as this was resulting in errors
JosefBredereck
approved these changes
Jun 21, 2021
Merged
38 tasks
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor: removed unused dependency iframe-resizer its usage seems to have been removed with commit 3c890c3 * refactor: removed unused dependencies critical and critical-css-webpack-plugin * refactor: removed unused dependency prerender-spa-plugin * refactor: updated svgo-loader depencency as this was resulting in errors * refactor: removed obsolete dependency fs-extra out of this package * refactor: removed obsolete dependency deepmerge out of this package * refactor: removed obsolete dependency core-js out of this package * refactor: removed obsolete dependency htm out of this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removed totally
packages/uikit-workshop/webpack.config.js)packages/uikit-workshop/webpack.config.js)packages/uikit-workshop/package.json, but hasn't been used within the codebase@sghoweri, do you probably remember whether this dependency has been evaluated and tested, but you've chosen
lit-htmlover that one in the end, so we could easily removehtmfrom thepackage.jsondependencies?Removed partly
fs-extra: removed frompackages/uikit-workshop/package.json, as itsrequiregot removed with commit 7136c8c (within filepackages/uikit-workshop/build-tools.json line 3)deepmerge: removed frompackages/uikit-workshop/package.json, as it was added with commit 8245e27, but never required within this packagecore-js: removed frompackages/uikit-workshop/package.json, as its usage out of e.g. commit 3c890c3 within theuikit-workshoppackage got extracted into an exclusive packageuikit-polyfills