General language adjustments #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d update UI messaging - Replace hardcoded '20' threshold with dynamic data.threshold in ConnectWalletBody - Remove 'Choose from below and verify' text from ScoreTooLowBody - Update messaging from 'wallet' to 'account' for broader compatibility - Maintain fallback to 20 when backend data unavailable
lebraat
changed the title
- Update Body.test.tsx for CongratsBody and ScoreTooLowBody text changes - Update PlatformVerification.test.tsx for error message and deduplication text updates - Update ScoreTooLowBody.test.tsx for heading, loading text, and navigation button changes - All tests now pass with updated messaging
- Update test mocks to use threshold: 20 instead of 25 - Update test expectation to match 'Reach 20+ by adding Stamps' - Ensures consistency with component's default fallback threshold
…guage updates - Revert error message changes in PlatformVerification.tsx - Revert deduplication text changes in PlatformVerification.tsx - Update corresponding test expectations to match reverted changes - Keep PR scope focused on main UI language improvements only
lucianHymer
reviewed
Aug 18, 2025
Member
Author
|
@lucianHymer -- Reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the hardcoded score threshold of '20' with the dynamic threshold value from the Django backend, providing partners the ability to set custom score thresholds.
Changes Made
Technical Details
Testing
Impact
Partners can now set custom score thresholds in the Django backend, and the frontend will automatically display the correct threshold value to users in both the ConnectWallet and ScoreTooLow screens.