enhancement: change sizes to bytes in hot tier #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can we add the " bytes" as a suffix to all the sizes? |
nitisht
requested changes
Aug 11, 2024
Member
nitisht
left a comment
nitisht
left a comment
There was a problem hiding this comment.
As we discussed let's make it in sync with other API, i.e.
- Add the " bytes" as a suffix to all the sizes e.g.
123324354 Bytes - Timezone info on the 'oldest_date_time_entry' e.g.
2011-08-12T20:17:46.384Z
nikhilsinhaparseable
force-pushed
the
hot-tier-size-bytes
branch
2 times, most recently
from
feff8dd to
c6bbf12
Compare
in PUT /logstream/{logstream}/hottier
request body:
`
{
"size": "10737418240"
}
`
the size is expected to be in bytes
GET /logstream/{logstream}/hottier
response body:
{
"size": "1073741824 Bytes",
"used_size": "121798121 Bytes",
"available_size": "951943703 Bytes",
"oldest_date_time_entry": "2024-08-10T11:45:00.000Z"
}
size, used_size, available_size are sent in bytes
suffixed "Bytes" to size, available_size and used_size
nikhilsinhaparseable
force-pushed
the
hot-tier-size-bytes
branch
from
c6bbf12 to
8bb311b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in PUT /logstream/{logstream}/hottier
request body:
{ "size": "10737418240" }the size is expected to be in bytes
GET /logstream/{logstream}/hottier
response body:
{
"size": "1073741824",
"used_size": "121798121",
"available_size": "951943703",
"oldest_date_time_entry": "2024-08-10 11:45:00"
}
size, used_size, available_size are sent in bytes