Skip to content

sanitise and remove reserved fields from alert other_fields #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2025
Merged

sanitise and remove reserved fields from alert other_fields #1462

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6916cb3
remove created from reserved fields
nikhilsinhaparseable Nov 11, 2025
e080b0f
remove reserved fields
nikhilsinhaparseable Nov 11, 2025
dc796e5
remove default created
nikhilsinhaparseable Nov 11, 2025
920be48
sanitise and remove reserved field from other_fields
nikhilsinhaparseable Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/alerts/alert_structs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,6 @@ use serde_json::Value;
use tokio::sync::{RwLock, mpsc};
use ulid::Ulid;

const RESERVED_FIELDS: &[&str] = &[
"id",
"version",
"severity",
"title",
"query",
"datasets",
"alertType",
"anomalyConfig",
"forecastConfig",
"thresholdConfig",
"notificationConfig",
"evalConfig",
"targets",
"tags",
"state",
"notificationState",
"created",
"lastTriggeredAt",
];

use crate::{
alerts::{
AlertError, CURRENT_ALERTS_VERSION,
Expand Down Expand Up @@ -336,15 +315,6 @@ impl AlertRequest {
other_fields.len()
)));
}

for key in other_fields.keys() {
if RESERVED_FIELDS.contains(&key.as_str()) {
return Err(AlertError::ValidationFailure(format!(
"Field '{}' cannot be in other_fields as it's a reserved field name",
key
)));
}
}
}

// Validate that all target IDs exist
Expand Down
Loading