Skip to content

Fix ParseFile MimeType guessing with uppercase extensions #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2018
Merged

Fix ParseFile MimeType guessing with uppercase extensions #399

merged 2 commits into from
Jul 25, 2018

Conversation

zeliard91
Copy link
Contributor

No description provided.

montymxb
montymxb approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this is good, nice catch. I'll go ahead and bring this in. Test additions look good, and CI in the master has been remedied. Expecting the test results should support this once CI in the master completes with this addition.

@montymxb montymxb merged commit 1b99d91 into parse-community:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@montymxb montymxb montymxb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeliard91 @montymxb