Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 13, 2025

New Pull Request Checklist

Issue Description

The server expects excludeKeys to be passed instead of excludedKeys

Added in Parse-Server 3.6.0 parse-community/parse-server#5737

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the request parameter for excluding fields in query results, ensuring the server properly recognizes excluded fields.
    • Improves compatibility with the API by using the correct parameter name.
    • No other behavior or logic changed; existing queries should continue to work, with field exclusion now functioning as expected.

Copy link

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Oct 13, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

coderabbitai bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

In PFRESTQueryCommand.m, the method findCommandParametersWithOrder:conditions:selectedKeys:includedKeys:excludedKeys:limit:skip:explain:hint:extraOptions:tracingEnabled:error: changes the parameter key used in the request payload from "excludedKeys" to "excludeKeys". No other logic or control flow is modified.

Changes

Cohort / File(s) Summary
Query parameter key rename
`Parse/Parse/Internal/Commands/PFRESTQueryCommand.m`
Replaced request parameter key "excludedKeys" with "excludeKeys" within findCommandParametersWithOrder:conditions:selectedKeys:includedKeys:excludedKeys:limit:skip:explain:hint:extraOptions:tracingEnabled:error:.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes the checklist and issue context but is missing required sections from the repository template, such as the Approach section, TODOs before merging, and a filled‐out issue closing reference, leaving the template incomplete. Update the description to fill in the Approach section, add a Closes reference for the related issue, complete any TODOs before merging, and mark checklist items appropriately to match the repository’s pull request template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly identifies the fix by highlighting the invalid parameter excludedKeys and concisely conveys the main change made to the codebase.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 078974e and 3e2afc9.

📒 Files selected for processing (1)
  • Parse/Parse/Internal/Commands/PFRESTQueryCommand.m (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Parse/Parse/Internal/Commands/PFRESTQueryCommand.m
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: LiveQuery Module, iOS 18
  • GitHub Check: Core Module, macOS 14
  • GitHub Check: Core Module, iOS 17
  • GitHub Check: Xcode 15
  • GitHub Check: Xcode 16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 13, 2025
This reverts commit 078974e.

fix: Invalid parameter `excludedKeys`

fix build 1
coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants