Skip to content

feat: Add support to include all pointers with PFQuery.includeAll #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat: Add support to include all pointers with PFQuery.includeAll #1734

merged 1 commit into from
Jul 14, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 11, 2023

New Pull Request Checklist

Issue Description

Includes all pointers without having to use multiple include().

Ref: parse-community/parse-server#4838

Closes: n/a

Approach

Same functionality to [query includeKey:@"*"]

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 11, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dplewis dplewis requested review from a team and mtrezza July 11, 2023 19:58
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 37.50% and project coverage change: -13.81 ⚠️

Comparison is base (98e5faf) 78.17% compared to head (03cbfb0) 64.37%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1734       +/-   ##
===========================================
- Coverage   78.17%   64.37%   -13.81%     
===========================================
  Files         307      200      -107     
  Lines       36865    23136    -13729     
===========================================
- Hits        28818    14893    -13925     
- Misses       8047     8243      +196
Impacted Files Coverage Δ
Parse/Parse/Source/PFQuery.m 94.24% <0.00%> (-0.59%) ⬇️
...e/Parse/Internal/Query/State/PFMutableQueryState.m 96.36% <100.00%> (+0.10%) ⬆️

... and 124 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza removed their request for review July 12, 2023 08:17
mtrezza
mtrezza approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza changed the title feat: Support query includeAll feat: Add support to include all pointers with PFQuery.includeAll Jul 14, 2023
@mtrezza mtrezza merged commit 04f81e8 into parse-community:master Jul 14, 2023
parseplatformorg pushed a commit that referenced this pull request Jul 14, 2023
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
8c9aa95 
# [2.5.0](2.4.0...2.5.0) (2023-07-14)

### Features

* Add support to include all pointers with `PFQuery.includeAll` ([#1734](#1734)) ([04f81e8](04f81e8))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.5.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 14, 2023
@dplewis dplewis deleted the include-all-keys branch July 14, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dplewis @parseplatformorg @mtrezza