Skip to content

test: Remove Parse.Cloud.job parameters from tests #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

test: Remove Parse.Cloud.job parameters from tests #2640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90c6b69
fix
mtrezza Jun 3, 2025
4e061ff
check params in job message
mtrezza Jun 3, 2025
5b21a8c
fix jobs data test
mtrezza Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions integration/test/IdempotencyTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ describe('Idempotency', () => {
it('handle duplicate job request', async () => {
DuplicateRequestId('1234');
const params = { startedBy: 'Monty Python' };
const jobStatusId = await Parse.Cloud.startJob('CloudJob1', params);
await expectAsync(Parse.Cloud.startJob('CloudJob1', params)).toBeRejectedWithError(
const jobStatusId = await Parse.Cloud.startJob('CloudJobParamsInMessage', params);
await expectAsync(Parse.Cloud.startJob('CloudJobParamsInMessage', params)).toBeRejectedWithError(
'Duplicate request'
);

Expand All @@ -49,7 +49,7 @@ describe('Idempotency', () => {
}
const jobStatus = await Parse.Cloud.getJobStatus(jobStatusId);
expect(jobStatus.get('status')).toBe('succeeded');
expect(jobStatus.get('params').startedBy).toBe('Monty Python');
expect(JSON.parse(jobStatus.get('message'))).toEqual(params);
});

it('handle duplicate POST / PUT request', async () => {
Expand Down
8 changes: 4 additions & 4 deletions integration/test/ParseCloudTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ describe('Parse Cloud', () => {

it('run job', async () => {
const params = { startedBy: 'Monty Python' };
const jobStatusId = await Parse.Cloud.startJob('CloudJob1', params);
const jobStatusId = await Parse.Cloud.startJob('CloudJobParamsInMessage', params);
expect(jobStatusId).toBeDefined();
await waitForJobStatus(jobStatusId, 'succeeded');

const jobStatus = await Parse.Cloud.getJobStatus(jobStatusId);
assert.equal(jobStatus.get('status'), 'succeeded');
assert.equal(jobStatus.get('params').startedBy, 'Monty Python');
expect(jobStatus.get('status')).toBe('succeeded');
expect(JSON.parse(jobStatus.get('message'))).toEqual(params);
});

it('run long job', async () => {
Expand Down Expand Up @@ -137,7 +137,7 @@ describe('Parse Cloud', () => {
it('get jobs data', done => {
Parse.Cloud.getJobsData().then(result => {
assert.equal(result.in_use.length, 0);
assert.equal(result.jobs.length, 3);
assert.equal(result.jobs.length, 4);
done();
});
});
Expand Down
4 changes: 4 additions & 0 deletions integration/test/cloud/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ Parse.Cloud.job('CloudJob2', function () {
});
});

Parse.Cloud.job('CloudJobParamsInMessage', request => {
request.message(JSON.stringify(request.params));
});

Parse.Cloud.job('CloudJobFailing', function () {
throw 'cloud job failed';
});
2 changes: 1 addition & 1 deletion integration/test/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const defaultConfiguration = {
},
},
idempotencyOptions: {
paths: ['functions/CloudFunctionIdempotency', 'jobs/CloudJob1', 'classes/IdempotentTest'],
paths: ['functions/CloudFunctionIdempotency', 'jobs/CloudJob1', 'jobs/CloudJobParamsInMessage', 'classes/IdempotentTest'],
ttl: 120,
},
fileUpload: {
Expand Down