Skip to content

fix: java package version always 1.0.0, current parse version not pushed to server #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2021
Merged

fix: java package version always 1.0.0, current parse version not pushed to server #1130

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4a756a
Update versioning
azlekov Oct 15, 2021
d90dd4f
Add PARSE_VERSION to current installation
azlekov Oct 15, 2021
e894cf0
Configure semantic release gradle plugin
azlekov Oct 15, 2021
e56b402
Pleases Spotless
azlekov Oct 15, 2021
31bedcc
Update release-automated.yml
azlekov Oct 15, 2021
4219d26
Merge branch 'master' into better-versioning
mtrezza Oct 17, 2021
a70105d
bump version
mtrezza Oct 18, 2021
eb8eee7
refactor gradle release step
mtrezza Oct 18, 2021
a879920
add npm package for local release testing
mtrezza Oct 18, 2021
4fa05d4
add npm package
mtrezza Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-automated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- uses: actions/setup-node@v2
with:
node-version: 14
- run: npm install -g -E [email protected] @semantic-release/[email protected] @semantic-release/[email protected] @semantic-release/[email protected] @semantic-release/[email protected]
- run: npm install -g -E [email protected] @semantic-release/[email protected] @semantic-release/[email protected] @semantic-release/[email protected] @semantic-release/[email protected] [email protected]
- run: npx semantic-release
env:
GH_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }}
Expand Down
12 changes: 6 additions & 6 deletions coroutines/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,22 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

Expand Down
19 changes: 13 additions & 6 deletions facebook/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,25 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Expand Down
12 changes: 6 additions & 6 deletions fcm/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

Expand Down
19 changes: 13 additions & 6 deletions google/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
Expand All @@ -27,6 +21,19 @@ android {
targetCompatibility JavaVersion.VERSION_1_8
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

kotlinOptions {
jvmTarget = "1.8"
}
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
version=2.0.1
android.enableJetifier=true
android.useAndroidX=true
14 changes: 6 additions & 8 deletions ktx/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,23 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

Expand Down
13 changes: 7 additions & 6 deletions parse/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
consumerProguardFiles "release-proguard.pro"
}

Expand All @@ -20,17 +18,20 @@ android {
}
}

packagingOptions {
exclude '**/BuildConfig.class'
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

Expand Down
2 changes: 2 additions & 0 deletions parse/src/main/java/com/parse/ParseInstallation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ private void updateVersionInfo() {
} catch (PackageManager.NameNotFoundException e) {
PLog.w(TAG, "Cannot load package info; will not be saved to installation");
}

performPut(KEY_PARSE_VERSION, BuildConfig.PARSE_VERSION);
}
}

Expand Down
3 changes: 2 additions & 1 deletion release.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ async function config() {
ci: true,
tagFormat: '${version}',
plugins: [
"gradle-semantic-release-plugin",
['@semantic-release/commit-analyzer', {
preset: 'angular',
releaseRules: [
Expand Down Expand Up @@ -79,7 +80,7 @@ async function config() {
'changelogFile': changelogFile,
}],
['@semantic-release/git', {
assets: [changelogFile],
assets: ["gradle.properties", changelogFile],
}],
['@semantic-release/github', {
successComment: getReleaseComment(),
Expand Down
12 changes: 6 additions & 6 deletions rxjava/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

Expand Down
19 changes: 13 additions & 6 deletions twitter/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,25 @@ android {
defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
}

packagingOptions {
exclude "**/BuildConfig.class"
}

lintOptions {
abortOnError false
}

buildTypes {
debug {
testCoverageEnabled = true
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
release {
minifyEnabled false
testCoverageEnabled = false
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
buildConfigField("String","PARSE_VERSION","\"${version}\"")
}
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Expand Down