Installation appVersion shows versionName instead of versionCode

[mtrezza]

Issue:
The Android SDK sets the app's versionName (e.g. 2.0) instead of its versionCode (e.g. build 200) in the Installation field appVersion.

Expected:
The build number (i.e. versionCode) should be set.

Rationale:
It makes sense to set the version code, because:

• server logic that is dependent on the build number can easily compare the versionCode being an integer, instead of versionName being a String.
• a build number more accurately identifies an app package than a version code.
• it contradicts the Parse iOS SDK which sets the app build number

However, correcting this inconsistency would be a breaking change for existing server logic.
Note: The API request header contains both, the build number and version name.

Affected Code:

Parse-SDK-Android/parse/src/main/java/com/parse/ParseInstallation.java

Line 212 in 0cfc67e

String appVersion = pkgInfo.versionName;

Parse-SDK-Android/parse/src/test/java/com/parse/ParseInstallationTest.java

Line 292 in 0cfc67e

String appVersion = pkgInfo.versionName;

[Jawnnypoo]

Hmm. Any thoughts on what to do here @flovilmart ?

[flovilmart]

Uhm, that’s indeed problematic as it’s been a while. Can we feature flag it so it’s picked at initialization time by the developer?

[mtrezza]

I like the feature flag idea. It should be also a feature in the iOS SDK then.

[flovilmart]

Good idea

[mtrezza]

I suggest tagging this as up for grabs, good first PR.

[mtrezza]

I'm going for just correcting the appVersion to be the build number for now. Otherwise there is an inconsistency with the Parse iOS SDK. This is a breaking change, but it's actually an overdue correction.

If we introduce a switch for the developer as to what appVersion means, we just create issues down the road because there we have 1 DB field that can be populated with 2 different properties. A better approach to me is to finally fix this bug, and if this is really a stopper for someone, then they can open a PR and add an additional column to the Installation collection for the "marketing version name".

@rogerhu can you take a look at this?