This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Time-based transaction banning #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
approved these changes
Aug 24, 2018
polkadot/transaction-pool/src/lib.rs
Outdated
|
|
||
| /// Removes timed bans. | ||
| pub fn clear_timeouts(&self, now: &Instant) { | ||
| let to_remove = { |
|
|
||
| /// Removes timed bans. | ||
| pub fn clear_timeouts(&self, now: &Instant) { | ||
| let to_remove = { |
There was a problem hiding this comment.
We were collecting the keys to remove using only the .read() lock. I changed the code though to acquire the lock only once.
| fn rotator() -> PoolRotator { | ||
| PoolRotator { | ||
| ban_time: Duration::from_millis(10), | ||
| ..Default::default() |
tomusdrw
commented
Aug 24, 2018
|
|
||
| /// Removes timed bans. | ||
| pub fn clear_timeouts(&self, now: &Instant) { | ||
| let to_remove = { |
There was a problem hiding this comment.
We were collecting the keys to remove using only the .read() lock. I changed the code though to acquire the lock only once.
gavofyork
added
A8-looksgood
and removed
A0-please_review
tomusdrw
added a commit
that referenced
this pull request
Aug 24, 2018
* Allow replacing transactions. * Clear old transactions and ban them temporarily. * Move to a separate module and add some tests. * Add bound to banned transactions. * Remove unnecessary block and double PoolRotator.
rphmeier
pushed a commit
that referenced
this pull request
Aug 24, 2018
dvdplm
added a commit
that referenced
this pull request
Aug 27, 2018
…and-rlpcodec * master: Contract signatures checking (#478) extrinsic-pool: use retain() (#613) rename Polkadot to Substrate in the license header via following four commands (#614) typo fixes (#608) RPC: Block number to block hash (#584) Minor fixes for nightly 2018-08-18 (#600) Time-based transaction banning (#594) (#602) cargo --force to allow CI to build. (#599) Fix logging (#587) Fix runtime version cache (#586)
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Fix xaccounts test build error * Modified xasset module mock * Update test * xassets module test ok * Update substrate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pool occupies the queue for more than 5 minutes: