This repository was archived by the owner on Feb 26, 2020. It is now read-only.
Fix build issues on Windows and ARM #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes sure that the RocksDB build won't set -march=native which doesn't work when cross-compiling
Author
|
Example failed builds: |
ordian
reviewed
Aug 29, 2018
|
|
||
| // NOTE: the cfg! macro doesn't work when cross-compiling, it would return values for the host | ||
| let target_arch = env::var("CARGO_CFG_TARGET_ARCH").unwrap_or_default(); | ||
| if target_arch == "arm" || target_arch == "aarch64" { |
There was a problem hiding this comment.
IIUC, we assume that the host arch is x86_64? And, ideally, we should check for host_arch != target_arch? But I'm not sure if there is a simple way to find out the value of the host_arch.
Author
There was a problem hiding this comment.
Indeed, I think -march=native would work if the host was ARM and it was building for ARM, but the crate should build on ARM nonetheless with the current changes.
The current build file isn't terribly portable and yes it makes some assumptions regarding the build environment, i.e. my priority was to make it work on parity-ethereum's CI.
debris
approved these changes
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some build issues introduced with the migration to CMake.
build.rsnow check thecrt-staticfeature to configure CMake accordingly.-march=nativewhich doesn't work when cross-compiling. DefiningPORTABLE=ONmakes sure the RocksDB build doesn't set-march=native.