Upgrade to Tokio 1.0 (and mio 0.7) #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simply a re-exported from std, so no change should be observed. Done to reduce explicit API surface used by Tokio the dependency.
Again, done to reduce explicit API surface used from Tokio
This was referenced Jun 29, 2021
tomusdrw
reviewed
Jun 30, 2021
Xanewok
commented
Jun 30, 2021
tomusdrw
approved these changes
Jun 30, 2021
|
@NikVolf can we move the repo to |
NikVolf
approved these changes
Jul 1, 2021
yep done |
|
Since it looks like it's well-reviewed, I'll go ahead and merge this. Thanks! Since we moved this repo, @NikVolf could you also please add https://crates.io/teams/github:paritytech:core-devs as the owner/publisher for https://crates.io/crates/parity-tokio-ipc? |
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Aug 24, 2021
Bump to Tokio 1.0 Closes #1695 Closes #1693 Just enabled by tokio-rs/tokio#3388. Work in progress to prune winapi 0.2, still needs patches upstreamed that migrate `parity-tokio-ipc` and `jsonrpc-*` crates to Tokio 1.0. Let's see what CI has to say, first. Blocked on: - [x] paritytech/parity-tokio-ipc#32 - [x] paritytech/jsonrpc#628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30.
Enabled by freshly merged tokio-rs/tokio#3388.
Needed to migrate
jsonrpc-*crates to Tokio 1.0 and primarily motivated by rust-lang/rls#1741 (fixes RLS build on aarch64-pc-windows-msvc by upgrading to winapi 0.3).