Fix canvg_context2d examples #3358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HackbrettXXX
requested changes
Jan 18, 2022
Collaborator
HackbrettXXX
left a comment
HackbrettXXX
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good except for my comment below.
`output()` to be called once per document
HackbrettXXX
approved these changes
Jan 21, 2022
Collaborator
HackbrettXXX
left a comment
HackbrettXXX
left a comment
There was a problem hiding this comment.
Alright. Looks good now. I'll merge it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes svg rendering examples in /examples/canvg_context2d/ directory to correctly render and display preview.
Before:
After:
Same approach can be used to progress #2983