refactor: extract Chainspec type from primitives

[guha-rahul]

re: #8674

Fixes: #7929
The error i am facing -

error: failed to load manifest for workspace member `/home/rahul/reth/bin/reth`

Caused by:
  failed to load manifest for dependency `reth-basic-payload-builder`

Caused by:
  failed to load manifest for dependency `reth-engine-primitives`

Caused by:
  failed to load manifest for dependency `reth-chainspec`

Caused by:
  failed to load manifest for dependency `reth-primitives`

Caused by:
  failed to parse manifest at `/home/rahul/reth/crates/primitives/Cargo.toml`

Caused by:
  error inheriting `reth_chainspec` from workspace root manifest's `workspace.dependencies.reth_chainspec`

Caused by:
  `dependency.reth_chainspec` was not found in `workspace.dependencies`

Even tho i have reth-chainspec = { path = "crates/storage/chainspec" } under [workspace.dependencies] .

[mattsse]

nice, a few nits and suggestions

[mattsse]

needs update

[guha-rahul]

there are some extra imports, will remove them when i get back electricity.

[mattsse]

needs regular lib.rs header, see other crates for ref

[mattsse]

I believe this is your error

Suggested change

	reth_chainspec.workspace = true
	reth-chainspec.workspace = true

[guha-rahul]

Got a cycle dependency error:-

error: cyclic package dependency: package `reth-chainspec v0.2.0-beta.6 (/home/rahul/reth/crates/chainspec)` depends on itself. Cycle:
package `reth-chainspec v0.2.0-beta.6 (/home/rahul/reth/crates/chainspec)`
    ... which satisfies path dependency `reth-chainspec` (locked to 0.2.0-beta.6) of package `reth-primitives v0.2.0-beta.6 (/home/rahul/reth/crates/primitives)`
    ... which satisfies path dependency `reth-primitives` (locked to 0.2.0-beta.6) of package `reth-chainspec v0.2.0-beta.6 (/home/rahul/reth/crates/chainspec)`
    ... which satisfies path dependency `reth-chainspec` (locked to 0.2.0-beta.6) of package `reth-engine-primitives v0.2.0-beta.6 (/home/rahul/reth/crates/engine-primitives)`
    ... which satisfies path dependency `reth-engine-primitives` (locked to 0.2.0-beta.6) of package `reth-basic-payload-builder v0.2.0-beta.6 (/home/rahul/reth/crates/payload/basic)`
    ... which satisfies path dependency `reth-basic-payload-builder` (locked to 0.2.0-beta.6) of package `reth v0.2.0-beta.6 (/home/rahul/reth/bin/reth)`
    ... which satisfies path dependency `reth` (locked to 0.2.0-beta.6) of package `beacon-api-sse v0.0.0 (/home/rahul/reth/examples/beacon-api-sse)`

Should removing reth-chainspec from crates/primitives solve it?

[mattsse]

we also need to delete chainspec from primitives crate

[guha-rahul]

hey @mattsse , just a quick clarification , when i am removing reth-chainspec from primitives, there are some functions that are imported to other crates, eg: revm_spec_by_timestamp_after_merge, so for those we have to explicitly pass the 'reth-primitives' or there is something i am missing?

[mattsse]

these functions we should also move

[guha-rahul]

these functions we should also move
I have identified 5 functions in the reth-primitives crate that are being used in other crates and they have chainspec in params.
eg: revm_spec_by_timestamp_after_merge is defined in primitive crate and i am having a mismatch type in reth-engine-primitives crate.
Can you please elaborate more on how we should move the functions?

[mattsse]

all chainspec usage needs to be removed from reth-primitives

if these are functions then we can move them to the new crate

[guha-rahul]

hey @mattsse , any feedback on the above commits?

[mattsse]

hmm, need to take a closer look at all the deps, but in essence this is exactly what we want

[mattsse]

okay, I made some progress here on figuring out how things should be structured.

what we need to do is keep a dependency on reth-primitives in the chainspec crate, so chainspec depends on reth-primitives

this should do it

[guha-rahul]

Regarding the failed tests, i am struggling to understand why i am getting errors in crates/net/eth-wire-types/src/receipt.rs

[Rjected]

just updated Cargo.lock which was preventing some tests from running

[Rjected]

could you remove the old chainspec now that it's in a separate crate, along with everything else that was copied to this new crate? we don't want to keep any duplicate files around

[mattsse]

I also want merge this after we have merged all changes in #8214

[guha-rahul]

could you remove the old chainspec now that it's in a separate crate, along with everything else that was copied to this new crate? we don't want to keep any duplicate files around

hey when I am trying to import the new chainspec in place of the old one , I am getting cyclic dependency errors and @mattsse previously mentioned we cannot import chainspec in reth-primitives since it will cause a cyclic dependency error.

[mattsse]

lgtm

[Rjected]

lgtm

[joshieDo]

thank you @guha-rahul!