ENH: pd.NamedAgg forwards *args and **kwargs to aggfunc #62729
+105
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Oct 18, 2025
|
|
||
|
|
||
| @set_module("pandas") | ||
| class NamedAgg(NamedTuple): |
There was a problem hiding this comment.
This seems too breaking. Previously, users could access NamedAgg.column after creation, but not if we inherit from tuple. Can we use a dataclass here instead:
@dataclasses.dataclass
class NamedAgg:
column: Hashable
aggfunc: AggScalar
args: tuple = ()
kwargs: dict = dataclasses.field(default_factory=dict)
def __init__(self, column: Hashable, aggfunc: AggScalar, *args, **kwargs) -> None:
self.column = column
self.aggfunc = aggfunc
self.args = args
self.kwargs = kwargs
def __getitem__(self, key: int):
if key == 0:
return self.column
elif key == 1:
return self.aggfunc
elif key == 2:
return self.args
elif key == 3:
return self.kwargs
raise IndexError("index out of range")We could then possibly deprecate __getitem__ access.
| >>> agg_1 = pd.NamedAgg(column=1, aggfunc=lambda x: np.mean(x)) | ||
| >>> df.groupby("key").agg(result_a=agg_a, result_1=agg_1) | ||
| result_a result_1 | ||
| >>> agg_b = pd.NamedAgg(column="b", aggfunc=lambda x: x.mean()) |
There was a problem hiding this comment.
I think the point here is to demonstrate that you can used a named tuple on columns that are not strings.
| return original_func(series, *final_args, **final_kwargs) | ||
|
|
||
| wrapped._is_wrapped = True # type: ignore[attr-defined] | ||
| aggfunc = wrapped |
There was a problem hiding this comment.
In line with the above, this changes the aggfunc which is a public attribute. Instead, I think we should utilize args/kwargs in places within pandas that accept a NamedAgg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.