Sparse array cumsum leads to infinite recursion 62669 #62703
Conversation
| if isinstance(self, SparseArray) and self.fill_value == 0: | ||
| # special case where we can avoid max recursion depth | ||
| return SparseArray(self.to_dense().cumsum()) |
There was a problem hiding this comment.
This fix seems to specific. Additionally especially for the open issue, it doesn't appear to_dense is needed
There was a problem hiding this comment.
Yeah, This fix is very specific to given use case.
` if isinstance(self, SparseArray) and self.fill_value == 0:
# special case where we can avoid max recursion depth
return SparseArray(self.cumsum())
If I don't add I am getting sameError: maximum recursion depth exceeded`
There was a problem hiding this comment.
I think the fix being specific is fine. It is basically using the same "trick" that the code was previously using for float arrays with nan fill, which was that if it is non-nan fill, densify and resparse so now the fill is nan, and call .cumsum() again. So it recurses once. This trick broke for integer arrays because when you do the densify and reparsing, the default fill is 0. This fix now catches that case ensuring that int arrays also only recurse once.
3 participants
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.