Add test for combine between two series #62674
Open
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_combine_series(self): | ||
| # GH#31899 | ||
| # Note - combine() with another Series is also tested elsewhere because | ||
| # it is used when testing operators |
There was a problem hiding this comment.
why is this comment moved?
There was a problem hiding this comment.
I understood this comment to be about testing combine with another Series. I didn't find other tests for this functionality, but assuming the comment holds true, I thought it might be more appropriate to move the comment to the new test that I've added since it deals with combine with another Series. If you want I can move it back or remove altogether.
There was a problem hiding this comment.
lets just get rid of it, doesnt seem to be adding any value
There was a problem hiding this comment.
other than that, LGTM. ping on green
mroeschke
added
the
Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int8converts them toInt64#31899doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature. N/A