-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
BUG fix for date_range 56134 #56831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG fix for date_range 56134 #56831
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
MarcoGorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
Thanks for updating!
it's fine, commits are squashed together anyway, the title of the PR is more important |
MarcoGorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best kind of bug fix - just, delete code, and the issue goes away
Looks good to me on green
Awesome stuff here @jrmylow !
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Edit, the first commit is incorrectly named - it fixes 56134 instead