Skip to content

BUG: Avoid intercepting TypeError in DataFrame.agg #49969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2022
Merged

BUG: Avoid intercepting TypeError in DataFrame.agg #49969

merged 2 commits into from
Dec 1, 2022

Conversation

yuvanist
Copy link
Contributor

@yuvanist yuvanist commented Nov 30, 2022 •
edited
Loading

@yuvanist yuvanist changed the title Bug: Avoid intercepting TypeError in DataFrame.agg BUG: Avoid intercepting TypeError in DataFrame.agg Nov 30, 2022
@yuvanist yuvanist mentioned this pull request Nov 30, 2022
Closed
jbrockmendel
jbrockmendel reviewed Nov 30, 2022
View reviewed changes
jbrockmendel
jbrockmendel reviewed Nov 30, 2022
View reviewed changes
@mroeschke mroeschke added Error Reporting Incorrect or improved errors from pandas Apply Apply, Aggregate, Transform, Map labels Dec 1, 2022
@yuvanist yuvanist requested a review from jbrockmendel December 1, 2022 01:59
rhshadrach
rhshadrach approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 2.0 milestone Dec 1, 2022
@jbrockmendel jbrockmendel merged commit d6918c1 into pandas-dev:main Dec 1, 2022
@jbrockmendel
Copy link
Member

thanks @yuvanist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Bug: Don't intercept TypeError in DataFrame.agg
4 participants
@yuvanist @jbrockmendel @rhshadrach @mroeschke