Skip to content

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

preliminary to de-duplicating some code in internals.construction

@pytest.mark.parametrize(
"index_can_append", indexes_can_append, ids=lambda x: type(x).__name__
)
@pytest.mark.parametrize(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all cases covered by existing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@jreback jreback added MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 31, 2021
@jreback
Copy link
Contributor

jreback commented May 31, 2021

question & can you add a whatsnew (this is catching another invalid case)? rebase & ping on green.

@jreback jreback added this to the 1.3 milestone May 31, 2021
@jreback jreback merged commit b9e96fa into pandas-dev:master Jun 1, 2021
@jbrockmendel jbrockmendel deleted the ref-homogenize branch June 1, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants