Skip to content

TST: GH30999 Add placeholder messages to pandas/tests/io/test_sql.py and remove test for numexpr < 2.6.8 #38920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2021
Merged

TST: GH30999 Add placeholder messages to pandas/tests/io/test_sql.py and remove test for numexpr < 2.6.8 #38920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ef2e57
TST: GH30999 test commit to run in the CI to figure out the error mes…
moink Jan 1, 2021
670630f
TST: GH30999 also comment out the pytest.skip
moink Jan 1, 2021
cf273ad
TST: 30999 add placeholder messages to test_sql and remove version ch…
moink Jan 3, 2021
d075a4a
Merge branch 'master' into add_match_msg_to_tests_skipped_on_my_dev_m…
moink Jan 3, 2021
65e3124
TST: 30999 uncomment pytest skip for TestXMySQL
moink Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pandas/tests/computation/test_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,10 @@ def testit():

if engine == "numexpr":
try:
import numexpr as ne
import numexpr as ne # noqa F401
except ImportError:
pytest.skip("no numexpr")
else:
if LooseVersion(ne.__version__) < LooseVersion(VERSIONS["numexpr"]):
with pytest.raises(ImportError):
testit()
else:
testit()
testit()
else:
testit()
4 changes: 2 additions & 2 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2896,7 +2896,7 @@ def test_execute_fail(self):
sql.execute('INSERT INTO test VALUES("foo", "bar", 1.234)', self.conn)
sql.execute('INSERT INTO test VALUES("foo", "baz", 2.567)', self.conn)

with pytest.raises(Exception):
with pytest.raises(Exception, match="<insert message here>"):
sql.execute('INSERT INTO test VALUES("foo", "bar", 7)', self.conn)

def test_execute_closed_connection(self, request, datapath):
Expand All @@ -2917,7 +2917,7 @@ def test_execute_closed_connection(self, request, datapath):
sql.execute('INSERT INTO test VALUES("foo", "bar", 1.234)', self.conn)
self.conn.close()

with pytest.raises(Exception):
with pytest.raises(Exception, match="<insert message here>"):
tquery("select * from test", con=self.conn)

# Initialize connection again (needed for tearDown)
Expand Down