TYP: annotate plotting._matplotlib.converter #35978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notate-plotting-converter
simonjayhawkins
approved these changes
Aug 29, 2020
|
|
||
|
|
||
| def period_break(dates, period): | ||
| def period_break(dates: PeriodIndex, period: str) -> np.ndarray: |
There was a problem hiding this comment.
the docsting says that dates is "dates : PeriodIndex" and goes on to say "Array of intervals to monitor." could a PeriodArray be passed?
There was a problem hiding this comment.
It is only ever called with PeriodIndex. I guess passing PeriodArray wouldnt break the world.
There was a problem hiding this comment.
while period_range returns a PeriodIndex there doesn't look like anything to gain by adding PeriodArray atm
|
Thanks @jbrockmendel |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Aug 31, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.