Skip to content

DOC: add note on str cons to read_sql #35503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

DOC: add note on str cons to read_sql #35503

merged 1 commit into from
Aug 1, 2020

Conversation

AdamSpannbauer
Copy link
Contributor

@AdamSpannbauer AdamSpannbauer commented Aug 1, 2020 •
edited
Loading

@simonjayhawkins
Copy link
Member

@arw2019

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 1, 2020
arw2019
arw2019 approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks @AdamSpannbauer

@simonjayhawkins simonjayhawkins merged commit 52e815f into pandas-dev:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@arw2019 arw2019 arw2019 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DOC: pd.read_sql() connection disposal for str type connections
3 participants
@AdamSpannbauer @simonjayhawkins @arw2019