Skip to content

CI: Making benchmark errors easier to find #29907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2019
Merged

CI: Making benchmark errors easier to find #29907

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1bac1c
CI: Making benchmark errors easier to find
datapythonista Nov 27, 2019
2f8e08c
Clearer output of benchmarks run
datapythonista Nov 28, 2019
52faf6a
Merge remote-tracking branch 'upstream/master' into benchmarks_annota…
datapythonista Nov 28, 2019
3056677
Fixing condition to fail benchmarks step
datapythonista Nov 28, 2019
0e39319
Avoid repeating the failing lines
datapythonista Nov 28, 2019
c77bccb
Removing raise in benchmark
datapythonista Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,18 @@ jobs:
git fetch upstream
if git diff upstream/master --name-only | grep -q "^asv_bench/"; then
asv machine --yes
ASV_OUTPUT="$(asv dev)"
if [[ $(echo "$ASV_OUTPUT" | grep "failed") ]]; then
echo "##vso[task.logissue type=error]Benchmarks run with errors"
echo "$ASV_OUTPUT"
asv dev | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using tee here instead of simply redirecting the sed output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the log to be shown in the CI, tee gets it printed (besides saving the file later used to see if there are failures and to save the artifact)

if grep "failed" benchmarks.log > /dev/null ; then
exit 1
else
echo "Benchmarks run without errors"
fi
else
echo "Benchmarks did not run, no changes detected"
fi
if: true

- name: Publish benchmarks artifact
uses: actions/upload-artifact@master
with:
name: Benchmarks log
path: asv_bench/benchmarks.log
if: failure()