Checks for left_index and right_index merge parameters #14434
Conversation
Current coverage is 85.25% (diff: 100%)@@ master #14434 diff @@
==========================================
Files 140 140
Lines 50631 50635 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43166 43171 +5
+ Misses 7465 7464 -1
Partials 0 0
|
pandas/tools/merge.py
Outdated
There was a problem hiding this comment.
pls use pandas.api.types.is_bool.
pandas/tools/merge.py
Outdated
There was a problem hiding this comment.
can u add tests to check expected error is raised?
pandas/tests/test_categorical.py
Outdated
There was a problem hiding this comment.
wrong file. should go in tools/tests/test_merge.py
|
Updated! |
|
Is there still any change to do? Thanks! |
pandas/tools/tests/test_merge.py
Outdated
There was a problem hiding this comment.
add the github issue reference as a comment
There was a problem hiding this comment.
Can you address this one?
|
pls add a whatsnew entry in 0.19.1. ping on green. |
…meters have correct types. Tests added.
|
Done! |
|
@jreback green |
|
|
||
| New features | ||
| ~~~~~~~~~~~~ | ||
| - Add checks to assure that left_index and right_index are of type bool |
There was a problem hiding this comment.
Can you move this to the bug fixes section? (I think that it is rather a bug that it accepted a wrong value, than a new feature that it now checks that)
pandas/tools/tests/test_merge.py
Outdated
There was a problem hiding this comment.
Can you address this one?
|
@jorisvandenbossche was your 2nd one the comment reference in the tests? (decided not a big deal) |
|
yep, but indeed not a big deal |
Author: Iván Vallés Pérez <[email protected]> Closes pandas-dev#14434 from ivallesp/add-check-for-merge-indices and squashes the following commits: e18b7c9 [Iván Vallés Pérez] Add some checks for assuring that the left_index and right_index parameters have correct types. Tests added.
…rameters Author: Iván Vallés Pérez <[email protected]> Closes #14434 from ivallesp/add-check-for-merge-indices and squashes the following commits: e18b7c9 [Iván Vallés Pérez] Add some checks for assuring that the left_index and right_index parameters have correct types. Tests added. (cherry picked from commit 2d3a739)
Hi,
I just committed an error when I was doing an analysis using pandas and this motivated me to implement two checks which in my opinion are necessary.
I was trying to perform a merge and I confused the parameters "left_on" and "right_on" for "left_index" and "right_index". I ran the code and it did not raised me any error. It produced a table which seem to be fine in terms of shape. I suspect that what happened is that the tables got merged by the index of the data frame. I think it would be a great idea to check if right_index and left_index are of type bool, if not, raise an error. This way we will avoid that more people got the same error as mine :D.
Tests passed
Thanks!