Skip to content

Add some missing types to BaseOffset and ExtensionArray #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

Add some missing types to BaseOffset and ExtensionArray #1330

merged 1 commit into from
Aug 18, 2025

Conversation

MarcoGorelli
Copy link
Member

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

MarcoGorelli
MarcoGorelli commented Aug 18, 2025
View reviewed changes
@MarcoGorelli MarcoGorelli changed the title improve typing of BaseOffset and ExtensionArray Add some missing types to BaseOffset and ExtensionArray Aug 18, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review August 18, 2025 11:32
Dr-Irv
Dr-Irv approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MarcoGorelli

@Dr-Irv Dr-Irv merged commit 0f14e32 into pandas-dev:main Aug 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @Dr-Irv