Skip to content

Issue1098 #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Issue1098 #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cabb19
issue 1098 added type support for complex in Series __add__ operator
Mar 13, 2025
23b588c
issue 1098 added test for complex in Series __add__ operator
Mar 13, 2025
1de98d2
added right order of __add__ overlay and testcases
shirzady1934 Mar 15, 2025
03d4c42
add pyright comment lines
Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pandas-stubs/core/series.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1577,6 +1577,22 @@ class Series(IndexOpsMixin[S1], NDFrame):
# just failed to generate these so I couldn't match
# them up.
@overload
def __add__( # pyright: ignore[reportOverlappingOverload]
self: Series[int], other: int
) -> Series[int]: ...
@overload
def __add__(self: Series[int], other: float) -> Series[float]: ...
@overload
def __add__(self: Series[int], other: complex) -> Series[complex]: ...
@overload
def __add__( # pyright: ignore[reportOverlappingOverload]
self: Series[float], other: int
) -> Series[float]: ...
@overload
def __add__(self: Series[float], other: float) -> Series[float]: ...
@overload
def __add__(self: Series[float], other: complex) -> Series[complex]: ...
@overload
def __add__(self, other: S1 | Self) -> Self: ...
@overload
def __add__(
Expand Down
14 changes: 14 additions & 0 deletions tests/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3538,6 +3538,20 @@ def test_series_reindex() -> None:
check(assert_type(s.reindex([2, 1, 0]), "pd.Series[int]"), pd.Series, np.integer)


def test_series_add_complex() -> None:
c = 1 + 1j
s = pd.Series([1.0, 2.0, 3.0])
check(assert_type(s + c, "pd.Series[complex]"), pd.Series)

c1 = 1
s1 = pd.Series([1.0, 2.0, 3.0])
check(assert_type(s1 + c1, "pd.Series[float]"), pd.Series)

c2 = 1
s2 = pd.Series([1, 2, 3])
check(assert_type(s2 + c2, "pd.Series[int]"), pd.Series)


def test_series_reindex_like() -> None:
s = pd.Series([1, 2, 3], index=[0, 1, 2])
other = pd.Series([1, 2], index=[1, 0])
Expand Down