Popen() list-argument pager process without shell=True
#3055
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
changed the title
Popen() list-arg pager process without shell=TruePopen() list-argument pager process without shell=True
Collaborator
|
@rolandwalker Thanks for the pr! Please add a changes.rst entry and we should be able to ship this with 8.3.1. 8.3.0 release in imminent. |
rolandwalker
force-pushed
the
pager-process-without-shell
branch
from
2523c7f to
e5cab46
Compare
Contributor
Author
|
Doc done, but wow did I mess up the branch! |
When the first argument to subprocess.Popen is a list, setting shell=True causes elements of the list to be discarded on POSIX platforms. Setting shell=False (the default) causes Popen() to invoke the first argument of the list and pass the rest of the arguments using "os.execvpe()-like behavior to execute the child program", per the subprocess docs at * https://docs.python.org/3/library/subprocess.html
rolandwalker
force-pushed
the
pager-process-without-shell
branch
from
e5cab46 to
7db1f20
Compare
rolandwalker
force-pushed
the
pager-process-without-shell
branch
from
be23496 to
7db1f20
Compare
Contributor
Author
|
I'm not sure I understand the relationship between |
Collaborator
|
Stable is for docs and bug fix release. Main is for feature releases. Basically allows us to release bug fixes while still working on features. That is fine. |
This was referenced Sep 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first argument to
subprocess.Popenis a list, settingshell=Truecauses elements of the list to be discarded on POSIX platforms.Setting
shell=False(the default) causesPopen()to invoke the first argument of the list and pass the rest of the arguments using "os.execvpe()-like behavior to execute the child program", per thesubprocessdocs atfixes #3039
I have looked at
tests/test_utils.pyand am unsure if this can be meaningfully tested.