Introduce ForUserAgent #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OStevan
added
help wanted
carterkozak
reviewed
Oct 21, 2021
tracing-api/src/main/java/com/palantir/tracing/api/TraceHttpHeaders.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Oct 21, 2021
tracing-jersey/src/main/java/com/palantir/tracing/jersey/TraceEnrichingFilter.java
Outdated
Show resolved
Hide resolved
tracing-jersey/src/main/java/com/palantir/tracing/jersey/TraceEnrichingFilter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carter Kozak <[email protected]>
carterkozak
reviewed
Oct 22, 2021
tracing-api/src/main/java/com/palantir/tracing/api/TracingHeadersEnrichingFunction.java
Show resolved
Hide resolved
Co-authored-by: Carter Kozak <[email protected]>
carterkozak
reviewed
Oct 22, 2021
tracing-okhttp3/src/main/java/com/palantir/tracing/OkhttpTraceInterceptor2.java
Show resolved
Hide resolved
carterkozak
reviewed
Oct 22, 2021
tracing-okhttp3/src/main/java/com/palantir/tracing/okhttp3/OkhttpTraceInterceptor.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Oct 22, 2021
carterkozak
reviewed
Nov 2, 2021
Comment on lines
19
to
24
| /** | ||
| * Internal header names meant for consumption only inside of the tracing codebase. | ||
| */ | ||
| public interface InternalTraceHttpHeaders { | ||
| String FETCH_USER_AGENT = "Fetch-User-Agent"; | ||
| } |
There was a problem hiding this comment.
This shouldn't be public if we can avoid it
tracing-api/src/main/java/com/palantir/tracing/api/TracingHeadersEnrichingFunction.java
Show resolved
Hide resolved
|
🍿🤖 |
|
Ah, we'll need another +1 here since the autorelease RC has my name on it... |
|
👍 |
jkozlowski
approved these changes
Nov 3, 2021
|
Released 6.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
When looking at the trace users needed to take a look at the whole trace to find out which service/FE-app started the request chain. With this PR the tracing library will propagate this information if set through the
ForUserAgentheader.After this PR
==COMMIT_MSG==
User agent specified inside
ForUserAgenthttp header will be propagated to requests made in the same trace.==COMMIT_MSG==
Possible downsides?
Possibly slight perf degradation as there is one more value to send/receive for every http request.
Concerns
ForUserAgentbased on standard user agent or should it only be propagated only if explicitly set? Something like this