Common trace state for tracing #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Oct 18, 2021
tracing/src/main/java/com/palantir/tracing/CommonTraceState.java
Outdated
Show resolved
Hide resolved
tracing/src/main/java/com/palantir/tracing/CommonTraceState.java
Outdated
Show resolved
Hide resolved
tracing/src/main/java/com/palantir/tracing/CommonTraceState.java
Outdated
Show resolved
Hide resolved
tracing/src/main/java/com/palantir/tracing/CommonTraceState.java
Outdated
Show resolved
Hide resolved
Comment on lines
120
to
121
| .traceId(trace.getCommonTraceState().getTraceId()) | ||
| .requestId(trace.getCommonTraceState().getRequestId()) |
There was a problem hiding this comment.
I'd probably keep around the getTraceId() and getRequetId() methods on Trace for conveience/readability. Not sure it buys us anything to deprecate the method. JIT gives us a budget for bytecode that can be inlined and optimized, so smaller methods (reusing common accessors) are more likely to be optimized in hot paths.
| ? new SampledDetachedSpan(operation, type, traceId, requestId, parentSpanId) | ||
| : new UnsampledDetachedSpan(traceId, requestId, parentSpanId); | ||
| ? new SampledDetachedSpan(operation, type, CommonTraceState.of(traceId, requestId), parentSpanId) | ||
| : new UnsampledDetachedSpan(CommonTraceState.of(traceId, requestId), parentSpanId); |
There was a problem hiding this comment.
nit: Might as well extract state creation above, and pass the reference to either the sampled or unsampled implementation.
Co-authored-by: Carter Kozak <[email protected]>
Co-authored-by: Carter Kozak <[email protected]>
carterkozak
reviewed
Oct 19, 2021
Co-authored-by: Carter Kozak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Based on comments from #782 I extracted a
CommonTraceStatewhich contains the requestId and traceId. I'm not sure about the following changes:getTraceIdandgetRequestIdbe removed completely?CommonTraceStateserializable introduced the nullable field for reqeustId and I'm not sure if the getter which wraps this nullable can be changed with something smarter.