Delete AsyncSlf4jSpanObserver #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
force-pushed
the
dfox/delete-AsyncSlf4jSpanObserver
branch
from
a726197 to
14d311a
Compare
|
Does this allow us to update the slf4j dependency in the |
carterkozak
reviewed
Aug 2, 2021
tracing-undertow/build.gradle
Outdated
| implementation project(':tracing-api') | ||
| implementation 'com.google.guava:guava' | ||
| implementation 'com.palantir.safe-logging:preconditions' | ||
| implementation "org.slf4j:slf4j-api" |
There was a problem hiding this comment.
This shouldn't be necessary after the safe-logger migration, just in testImplementation, right?
There was a problem hiding this comment.
Yep, after merging in develop this disappeared
iamdanfox
changed the title
iamdanfox
force-pushed
the
dfox/delete-AsyncSlf4jSpanObserver
branch
from
702f4d2 to
2022d31
Compare
iamdanfox
changed the title
carterkozak
reviewed
Aug 2, 2021
| com.fasterxml.jackson.core:jackson-annotations:2.12.3 (18 constraints: fa20d0ea) | ||
| com.fasterxml.jackson.core:jackson-core:2.12.3 (18 constraints: f5617cda) | ||
| com.fasterxml.jackson.core:jackson-databind:2.12.3 (26 constraints: 8cf4d2b4) | ||
| com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.12.3 (4 constraints: 1e3f528b) |
carterkozak
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
A sourcegraph search shows the only usages of
AsyncSlf4jSpanObserverare in archived repos (so no longer writeable), or abandoned personal copies of http-remoting.There is however one usage in tritium's tests: https://github.com/palantir/tritium/blob/14084bccbaf34133af38d5da2c52b136e0c0b9aa/tritium-tracing/src/test/java/com/palantir/tritium/tracing/TracingInvocationEventHandlerTest.java#L71, which I'm deleting here palantir/tritium#1172
I'd like to delete the parts of tracing-java's API that we no longer use so that any attempt to try out different internals (e.g. OpenTelemetry) is a bit easier.
After this PR
==COMMIT_MSG==
Delete
AsyncSlf4jSpanObserver- internally we construct a SpanObserver which uses log4j2 to ensure that spans are serialized and logged without blocking threads that produce spans.==COMMIT_MSG==
Possible downsides?