Skip to content

Delete deprecated AsyncTracer #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Delete deprecated AsyncTracer #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24c9496
Delete deprecated AsyncTracer
iamdanfox Aug 2, 2021
41e2370
revapi
iamdanfox Aug 2, 2021
e9b9a54
Add generated changelog entries
svc-changelog Aug 2, 2021
6451fa2
Add generated changelog entries
svc-changelog Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .palantir/revapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,8 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.util.Optional<java.lang.String> com.palantir.tracing.TraceMetadata::getRequestId()"
justification: "immutables are not for extension"
"5.0.0":
com.palantir.tracing:tracing:
- code: "java.class.removed"
old: "class com.palantir.tracing.AsyncTracer"
justification: "Sourcegraph search shows zero usages of this class"
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-753.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: break
break:
Copy link
Contributor Author

@iamdanfox iamdanfox Aug 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only other thought about calling this a break and cutting another major rev is would we want to also delete any other deprecated things (like OkhttpTraceInterceptor) perhaps??

or:

@Deprecated
    public static OpenSpan of(String operation, String spanId, SpanType type, Optional<String> parentSpanId)

also

AsyncSlf4jSpanObserver

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major revs are cheap, we can dev a few times. If there are other breaks you’d like to make in the same major rev as this one we can merge them around the same time.

description: The deprecated `AsyncTracer` class is deleted.
links:
- https://github.com/palantir/tracing-java/pull/753
85 changes: 0 additions & 85 deletions tracing/src/main/java/com/palantir/tracing/AsyncTracer.java
View file
Open in desktop

This file was deleted.

98 changes: 0 additions & 98 deletions tracing/src/test/java/com/palantir/tracing/AsyncTracerTest.java
View file
Open in desktop

This file was deleted.