Add benchmark for comparing versions #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
previously approved these changes
Aug 29, 2025
| RC_SNAPSHOT("0.16.0-rc1-8-g116b425"), | ||
| ; | ||
|
|
||
| private final OrderableSlsVersion version; |
Member
There was a problem hiding this comment.
Suggested change
| private final OrderableSlsVersion version; | |
| private final OrderableSlsVersion version1; |
policy-bot
bot
dismissed
pkoenig10’s stale review
Invalidated by push of f102dd2
pkoenig10
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We're looking to introduce some changes to the version comparison logic in #1183 and/or #1179, but we don't actually have a benchmark to determine whether these are going to impact the performance (whether positively or negatively)
After this PR
==COMMIT_MSG==
Add benchmark for comparing versions
==COMMIT_MSG==
Possible downsides?