Streamline and improve performance for orderable sls version parsing #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldexis
commented
Aug 25, 2025
| return getValue(); | ||
| } | ||
|
|
||
| private static int groupAsInt(String value, Matcher matcher, int group) { |
There was a problem hiding this comment.
Extracted out from RegexMatchResult, since it felt unnecessary to have the entire class + the parsers just for this (especially since NonOrderableSlsVersion is the less common usecase).
I'll move this to a separate util class though
| import com.palantir.logsafe.Preconditions; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| enum OrderableSlsVersionParser { |
There was a problem hiding this comment.
I should add some javadoc here (even though it was missing from ReleaseVersionParser)
aldexis
force-pushed
the
ald/better-sls-version-comparison
branch
from
5067776 to
43cc394
Compare
|
While this might indeed improve performance, there is no indication so far that this is needed anywhere. As such, I'll close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
When parsing an orderable sls version, we're doing up to 4 parsing of the same string (one for each version type), which is fairly inefficient and leads to extra code as well.
We've also implemented a dedicated, more optimized version parser for release versions in #463, which can be easily extended to the other version types, but for these we're still relying on the basic regex parsing.
After this PR
==COMMIT_MSG==
Streamline orderable sls version parsing
==COMMIT_MSG==
Performance comparison shows high improvements on both speed and memory allocations for non-release version parsing. Specifically surfacing these:
See complete JMH results below:
Before (as of #1183)
After
This PR also removes a few now-unnecessary package-private classes
Possible downsides?