Skip to content

Conversation

@sfackler
Copy link
Member

@sfackler sfackler commented Apr 17, 2025

Before this PR

By default, Conjure errors received from other services would turn into an error that would not propagate any of the upstream info, including its instance ID. This doesn't match the behavior of conjure-java as of palantir/conjure-java-runtime-api#348.

After this PR

==COMMIT_MSG==
The error instance ID of remote errors is now propagated.
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Apr 17, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The error instance ID of remote errors is now propagated.

Check the box to generate changelog(s)

  • Generate changelog entry

@sfackler sfackler force-pushed the propagate-error-instance-id branch from 312dcd9 to 8b014a3 Compare April 17, 2025 13:28
@sfackler sfackler force-pushed the propagate-error-instance-id branch from 8b014a3 to 082d2ab Compare April 17, 2025 13:29
@stale
Copy link

stale bot commented Jun 27, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Jun 27, 2025
@sfackler sfackler removed the stale label Jun 30, 2025
@bulldozer-bot bulldozer-bot bot merged commit a3441a3 into develop Jul 2, 2025
4 checks passed
@bulldozer-bot bulldozer-bot bot deleted the propagate-error-instance-id branch July 2, 2025 18:56
@autorelease3
Copy link

autorelease3 bot commented Jul 2, 2025

⚠️ Release Failed

Label releases are not allowed to increment the major version number

If you know how to resolve this error or believe it was temporary, you can try a manual release using the Autorelease UI.

Otherwise, please reach out to #help-devtools for assistance and include d1io1p51s8gc738mt6jg as your error ID.

sfackler added a commit that referenced this pull request Aug 11, 2025
The error instance ID of remote errors is now propagated.

(cherry picked from commit a3441a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants